Fix, use "service.build.ulimits" when it is present instead of "service.ulimits"

containers / podman-compose

a script to run docker-compose.yml using podman

GNU General Public License v2.0

4.86k stars 465 forks source link

Fix, use "service.build.ulimits" when it is present instead of "service.ulimits" #906

Closed camspiers closed 2 months ago

camspiers commented 3 months ago

https://github.com/compose-spec/compose-spec/pull/433

camspiers commented 3 months ago

Hey @p12tic thanks for reviewing the PR. I have updated with unit tests, but I am not 100% on what I have done.

At the moment I am testing both that the ulimits are passed correctly to the build command, and that the ulimits are applied during the build. However I could solely test that the right arguments are passed to the build command using the dry-run flag and remove the actual execution of the ulimit command in the build.

p12tic commented 2 months ago

Rebased and shortened commit message to max 72 chars allowed by git.