Don't create pods/container when registering systemd unit

containers / podman-compose

a script to run docker-compose.yml using podman

GNU General Public License v2.0

4.86k stars 465 forks source link

Don't create pods/container when registering systemd unit #923

Closed winston-yallow closed 2 months ago

winston-yallow commented 2 months ago

Closes #922 by removing the side effect from the systemd register action.

Contributor Checklist:

this PR is outside of the scope of the compose spec as it is systemd related.
no unit tests have been changes since the code that was removed wasn't tested before.

winston-yallow commented 2 months ago

It seems like the DCO bot is not happy with my "Signed-off-by" line since I used the anonymized github mail there, which works for signing commits (you can see it is verified) but apparently does not satisfy the bot. got it working, my bad

p12tic commented 2 months ago

Looks like I can override DCO bot, which is reasonable in this case.

winston-yallow commented 2 months ago

Already figured it out, my local git client did the signing wrong. Edited it manually, sorry for the hassle :sweat_smile:

p12tic commented 2 months ago

Ah, now it's signed as expected by the bot, thanks.

winston-yallow commented 2 months ago

thanks for the fast merge!