search

containers / podman-compose

a script to run docker-compose.yml using podman
GNU General Public License v2.0
4.86k stars 465 forks source link

Broken support for Containerfile #929

Closed uosis closed 1 week ago

uosis commented 2 months ago

Describe the bug

https://github.com/containers/podman-compose/pull/686 broke support for using Containerfile instead of Dockerfile for builds. Dockerfile hardcoded here:

https://github.com/containers/podman-compose/pull/686/files#diff-956dd8b5765533c7e8f5bb94c8a1b4735dfcfd9cff54829f3494b87460fab50bR1297

which causes this logic to be skipped:

https://github.com/containers/podman-compose/blob/main/podman_compose.py#L2238

To Reproduce

Try to build any compose file that has build: . or similar and Containerfile instead of Dockerfile.

Expected behavior Containerfile to be detected as before. Actual behavior Containerfile not detected

Output

$ podman-compose version
podman-compose version 1.1.0
podman version 5.0.2

Environment: