Closed axel7083 closed 5 months ago
I'm not sure about adding stuff around CONFIG_PATH as it's never used in the extension and for the other env variables as well (except MODEL_PATH, HOST and PORT)
I removed the code related to the config file
I'm still wondering, if ai lab is the only thing using these images if we should not remove env var that are not yet provided by Ai lab
like GPU_LAYERS
and CLIP_MODEL_PATH
and add them the day it'll be handled
but then side question, how ai lab is ensuring that the image is matching the precondition.
if I have the extension being installed for a while and update the extension, will it update the image or notify that the service is no longer compliant ?
I'm still wondering, if ai lab is the only thing using these images if we should not remove env var that are not yet provided by Ai lab
like
GPU_LAYERS
andCLIP_MODEL_PATH
I am in favour of keeping them
and add them the day it'll be handled
but then side question, how ai lab is ensuring that the image is matching the precondition.
if I have the extension being installed for a while and update the extension, will it update the image or notify that the service is no longer compliant ?
We have nothing keeping track of the version
What does this PR do?
The current script in this repository is out of date compared to the one in https://github.com/containers/ai-lab-recipes/blob/main/model_servers/llamacpp_python/src/run.sh
Screenshot / video of UI
What issues does this PR fix or reference?
Related to https://github.com/containers/podman-desktop-extension-ai-lab/issues/825
How to test this PR?
podman build ./chat