containers / podman-desktop-extension-ai-lab

Work with LLMs on a local environment using containers
https://podman-desktop.io/extensions/ai-lab
Apache License 2.0
145 stars 23 forks source link

Use FormPage for Import Model page #1230

Closed feloy closed 1 week ago

feloy commented 1 week ago

What does this PR do?

Updtae the "Import Model" page to use the dedicated FormPage component instead of NavPage

Also change a few colors to support light mode (except colors in the form itself)

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #1229

How to test this PR?

Navigate to Catalog > Import

feloy commented 1 week ago

One small issue

[...] We have a clear improvement on the light mode (nice job), but we loose the separation between the secondary navigation and the content on both theme

Do you mean the vertical shadow between the 2 zones? If so, this issue tracks the problem: https://github.com/containers/podman-desktop/issues/7549

axel7083 commented 1 week ago

Do you mean the vertical shadow between the 2 zones? If so, this issue tracks the problem:

Sorry if I was not clear enough, the fact that the main and secondary navigation are both the same color:

image

feloy commented 1 week ago

Do you mean the vertical shadow between the 2 zones? If so, this issue tracks the problem:

Sorry if I was not clear enough, the fact that the main and secondary navigation are both the same color:

image

I double-checked, and for me the 2 colors were already before really the same (#343434), but the shadow in the middle makes one think they are different