search

containers / podman-desktop-extension-ai-lab

Work with LLMs on a local environment using containers
https://podman-desktop.io/extensions/ai-lab
Apache License 2.0
170 stars 31 forks source link

Create a form to start a new InstructLab session #1617

Open jeffmaury opened 1 month ago

jeffmaury commented 1 month ago

Only the UI workflow should be implemented as we are investigating the images

axel7083 commented 3 days ago

Here is my first draft implentation for the StartInstructLabSession page.

image

image

Mock-ups vs Implementation

image

Above is the mock-ups available on penpot.

  1. Why are we using dropdowns for sections ? This is not something we are doing anywhere in podman-desktop.
  2. Why the session name is the last field ? This feel a bit weird to give a name at the end
  3. Model selection do not match design of StartRecipe and CreateService.

The inspiration for (+) Adding knowledge and (+) Adding skills are from the Container Import page

image

Going deeper

I was curious to see how we could give more information about each section, and redirect user to the Instructlab repository to learn more on what is a skill and what is a knowledge, but not sure.

image

I tried adding (?) next to the form labels, but I feel like the link color get redundant and weird on the eyes.

Form validation

To make the submit button valid, I used the following

https://github.com/containers/podman-desktop-extension-ai-lab/blob/2a1f82e5dd93c5f08894e1650cea7ae4f97dba42/packages/frontend/src/pages/StartInstructLabSession.svelte#L22

This mean either a skills or a knowledge is necessary (a combination is possible but at least one of them is required)

Current branch

I am working on https://github.com/axel7083/ai-studio/tree/feat/start-instructlab-session if people want to experiment with the form.

cc @slemeur @jeffmaury

slemeur commented 3 days ago

cc @MariaLeonova

MariaLeonova commented 3 days ago

@axel7083 seems like we're working in parallel on some of the UI changes and will need to sync going forward.

Firstly, please take a look at these enhancement suggestions that I have logged for InstructLab integration:

Secondly, there's some further work planned for IL mockups, that will be tracked in this epic: https://github.com/containers/podman-desktop-extension-ai-lab/issues/1743

As for the screens you're suggesting in this issue, I think the best way to go would be to have an in-person chat and go through all the questions.

For instance, #1788 is addressing your point on providing people with extra guidance.

axel7083 commented 3 days ago

As for the screens you're suggesting in this issue, I think the best way to go would be to have an in-person chat and go through all the questions.

Yeah! Thanks for the precisions, I also think that's the best way to do !