search

containers / podman-desktop-extension-ai-lab

Work with LLMs on a local environment using containers
https://podman-desktop.io/extensions/ai-lab
Apache License 2.0
170 stars 31 forks source link

chore: switch to pnpm instead of yarn #1653

Closed jeffmaury closed 2 weeks ago

jeffmaury commented 3 weeks ago

Fixes #1652

What does this PR do?

Switch package manager from yarn to pnpm

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

1652

How to test this PR?

Execute build

axel7083 commented 3 weeks ago

The error 33:7 error Parsing error: Unexpected character '@' seems to be related to the following

https://github.com/containers/podman-desktop-extension-ai-lab/blob/9ebb102fb78c4980cf7e8e1c8209d2fe680edaab/packages/frontend/src/lib/button/CopyButton.svelte#L33

which may be because eslint is not properly configured for svelte 5

cc @benoitf

benoitf commented 3 weeks ago

which may be because eslint is not properly configured for svelte 5

but currently it's passing so somehow it's related to this PR

benoitf commented 3 weeks ago

it's missing this file https://github.com/containers/podman-desktop/blob/main/.npmrc

benoitf commented 3 weeks ago

Looks like you also need to provide the pnpm file with the workspace definition

benoitf commented 3 weeks ago

https://raw.githubusercontent.com/containers/podman-desktop/main/pnpm-workspace.yaml

benoitf commented 2 weeks ago

@jeffmaury if you could update the lock file

jeffmaury commented 2 weeks ago

See https://github.com/postmanlabs/postman-code-generators/issues/760

ScrewTSW commented 2 weeks ago

@jeffmaury I think tests/playwright are missing pnpm-lock.yaml, or is it all handled in the root project?

benoitf commented 2 weeks ago

@ScrewTSW there is only one lock file per project (it is handling all workspaces defined in pnpm-workspace file)