chore: enable pre-commit

containers / podman-desktop-extension-ai-lab

Work with LLMs on a local environment using containers

https://podman-desktop.io/extensions/ai-lab

Apache License 2.0

183 stars 41 forks source link

chore: enable pre-commit #1979

Closed maryamtahhan closed 1 month ago

maryamtahhan commented 1 month ago

What does this PR do?

Enables pre-commit hook for the repo.
Runs the pre-commit plugins on the files in the repo and applied the relevant changes.

How to test this PR?

pip install pre-commit
pre-commit install
pre-commit run --all-files

axel7083 commented 1 month ago

Thanks @maryamtahhan, I do not think podman-desktop related repository are familair with pre-commit, on podman-desktop repository we seems to be using husky^1, we also have an issue related to using it on ai-lab https://github.com/containers/podman-desktop-extension-ai-lab/issues/1633

jeffmaury commented 1 month ago

Thanks for your contribution. However, it requires Python which is too much. Podman Desktop uses Husky for such, would you mind going that direction ?

maryamtahhan commented 1 month ago

No problem - I can break down the issues the pre-commit hooks picked up into separate PRs (without the actual pre-commit hook itself)...

I will have a look at the husky route.

benoitf commented 1 month ago

also for the trailing spaces, EOF the repository is using prettier but maybe some files are ignored/skipped explaining why few files have problems