search

containers / podman-desktop-extension-bootc

Support for bootable OS containers (bootc) and generating disk images
Apache License 2.0
403 stars 13 forks source link

feat: be able to use build config #615

Closed cdrage closed 1 month ago

cdrage commented 1 month ago

feat: be able to use build config

What does this PR do?

Screenshot / video of UI

Screenshot 2024-07-09 at 2 00 25 PM

What issues does this PR fix or reference?

Closes https://github.com/containers/podman-desktop-extension-bootc/issues/471

How to test this PR?

  1. Use our test bootc image
  2. Create a TOML file with the following:
[[customizations.user]]
name = "root"
password = "letmein"
  1. Build image
  2. Confirm you can login
  3. Test again with a JSON file: 
    {
"customizations": {
"user": [
  {
    "name": "root",
    "password": "letmein2"
  }
]
}
}

Signed-off-by: Charlie Drage charlie@charliedrage.com

cdrage commented 1 month ago

Screenshot 2024-07-10 at 8 24 23 AM

Updated the PR, I've also adjusted the classes a bit / styling so that the spacing is better for the AWS section as well.

Ready for another review 👍

deboer-tim commented 1 month ago

Ready for another review 👍

LGTM, previous approval still good.