search

containers / podman-desktop-extension-minikube

Apache License 2.0
3 stars 8 forks source link

refactor(MinikubeDownload): expose extension executable path #170

Closed axel7083 closed 2 weeks ago

axel7083 commented 2 weeks ago

Following @benoitf comment https://github.com/containers/podman-desktop-extension-minikube/pull/165#issuecomment-2420641623 trying to make very small changes.

This PR expose the path where the executable will be located inside the extension folder. This will be useful in other component to be able to use it to execute <minikube-path> --version.

Notable change

The MinikubeDownload was saving the executable in <extension-folder>/bin/minikube(.exe) but the MinikubeInstaller is saving to <extension-folder>/minikube-<platform>-<arch>(.exe). To simplify that, this PR remove the bin folder, as it is not used by any extensions (kind, compose, etc.)

Tests

benoitf commented 2 weeks ago

(just need to fix the formatting)