containers / podman-desktop

Podman Desktop - A graphical tool for developing on containers and Kubernetes
https://podman-desktop.io
Apache License 2.0
4.46k stars 283 forks source link

Tray Icon Color not updating on Windows 10 Pro #2622

Open codermonkey55 opened 1 year ago

codermonkey55 commented 1 year ago

Bug description

As shown in the screenshot below, I've changed the "Tray Icon Color" preference to light but it remains unchanged in the taskbar. Additionally, the "(Requires restart)" note in parentheses is ambiguous and does not explicitly state what needs to be restarted - I've tried restarted the podman machine, the podman desktop, I've even restarted my windows machine, all while have the preference set to "Light" and it still remains dark.

I'm certain at this point that this is a bug.

image

Operating system

Windows 10 Pro 22H2

Version

1.0.x

Steps to reproduce

Relevant log output

No response

Additional context

Edition Windows 10 Pro Version 22H2 Installed on ‎5/‎14/‎2023 OS build 19045.2965 Experience Windows Feature Experience Pack 1000.19041.1000.0

benoitf commented 1 year ago

thanks for the report @codermonkey55

the restart should be like: right click on the tray icon and then exit, then relaunch Podman Desktop (but you did reboot your computer so it should have worked as well)

I'll need to check with a developer on Windows

jeffmaury commented 1 year ago

Tested on Win10 and don't see a change after Podman Desktop restart

jeffmaury commented 1 year ago

Tested on Win10 and don't see a change after Podman Desktop restart

After several tests it seems related to the Windows theme: if you select the light theme then the tray icon is updated accordingly with the setting.

lstocchi commented 1 year ago

I didn't test on Win10 but i'm quite sure it is the same behavior. I think @codermonkey55 was expecting a different color when switching to light. The light one is actually black so there are no problem with the setting update. I tried and the icon gets updated @mairin should we switch the icons?

Dark image

Light image

mairin commented 1 year ago

Sure I can do.

curd0 commented 9 months ago

The issue is still reproducible in the latest v.1.5.2

image

Edition Windows 11 Enterprise Version 22H2 Installed on ‎6/‎9/‎2023 OS build 22621.2428 Experience Windows Feature Experience Pack 1000.22674.1000.0

dgolovin commented 9 months ago

This is happening to me too, but only if I use 'Custom' theme in windows settings.

curd0 commented 9 months ago

This is happening to me too, but only if I use 'Custom' theme in windows settings.

Yes, the same here. I use 'Custom' theme: light Apps, dark Windows

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

ciros88 commented 2 months ago

happens on manjaro kde (breath dark theme) too: tray icon color set both to light or dark is always dark (also after having restarted podman desktop)