containers / podman-desktop

Podman Desktop is the best free and open source tool to work with Containers and Kubernetes for developers. Get an intuitive and user-friendly interface to effortlessly build, manage, and deploy containers and Kubernetes — all from your desktop.
https://podman-desktop.io
Apache License 2.0
4.7k stars 296 forks source link

Allow to restore native title bar #2647

Open benoitf opened 1 year ago

benoitf commented 1 year ago

Is your enhancement related to a problem? Please describe

mostly for Linux (and maybe Windows), some people want to have their native title bar instead of the Podman Desktop integrated bar even if it displays like 'two bars'

https://github.com/containers/podman-desktop/issues/1802#issuecomment-1563372280

Describe the solution you'd like

Add an option to add 'double title bar'

Describe alternatives you've considered

No response

Additional context

No response

afbjorklund commented 1 year ago

Having an option to use the system's window titles and frames, like is available in Chromium, would be a good thing

here a normal window on Linux, and podman:

image

(there is no minimize button, in elementary.io)

But it probably would also require system theme for the content, since otherwise it could clash quite bad with the UI?

mairin commented 1 year ago

Another possibility would be options to turn off the min / max buttons. Like how gnome tweak ui lets you turn them on.

alexojegu commented 1 year ago

Why not just use the native title bar, with the title "Podman Desktop" in it? Without double title bar like Visual Studio Code or Beekeeper Studio.

Captura desde 2023-05-28 20-27-10

Captura desde 2023-05-28 20-31-38

mairin commented 1 year ago

@alexojegu The native titlebar would be preferable but theres an issue with electron that causes double titlebars on Linux.

alexojegu commented 1 year ago

@mairin I may be wrong, but the two apps I mentioned above are electron and I don't see a double title bar. maybe because of the electron version?

mairin commented 1 year ago

@alexojegu No you're not wrong, that is the case :) I don't know why it happens - I had played a bit with trying to get the native titlebar working without much luck. Electron handles Linux titlebars a bit differently and there are methods in Electron available for styling the Mac and Windows ones that have not been implemented for Linux. I am no Electron expert though! But as a UX designer - I would say this is what would be preferred from most preferred to least preferred:

  1. Native titlebars on each platform including linux
  2. A single titlebar on each platform, even if its not native (Mac OS native, Windows+Linux custom is what we have right now)
  3. Double titlebars on Windows and Linux

We were at #3 before, and I felt for 1.0 it would be more polished to have a single titlebar. When I did some demos on Linux to users leading up to the 1.0 release, the double titlebar was something a lot of people commented on looking and feeling pretty awkward. So we've achieved #2 for the 1.0 release. In the future, in my opinion, it would be quite nice if we could have a native titlebar on every platform and I think it's something worth trying to achieve, but I think incrementally if folks want the option to have the native double bar [or, to turn off the extra - and [] buttons on the custom one] sooner rather than later, that's an ok thing to do.

Does that make sense?

alexojegu commented 1 year ago

@mairin Thanks by the explication.

As temporary workaround I can live with custom titlebar. But in my opinion, to long term I prefer the native titlebar... with double titlebar if there is no other solution.

In case it can help, here's how Beekeeper Studio creates the window: https://github.com/beekeeper-studio/beekeeper-studio/blob/master/apps/studio/src/background/WindowBuilder.ts

When it is native seems to use, for Linux and Mac:

BrowserWindow({
  titleBarStyle: 'hidden',
  frame: true
})

And for Windows:

BrowserWindow({
  titleBarStyle: 'default',
  frame: true
})
github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

alexojegu commented 7 months ago

The issue is still relevant.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

alexojegu commented 1 month ago

The issue is still relevant.