containers / podman-desktop

Podman Desktop is the best free and open source tool to work with Containers and Kubernetes for developers. Get an intuitive and user-friendly interface to effortlessly build, manage, and deploy containers and Kubernetes — all from your desktop.
https://podman-desktop.io
Apache License 2.0
4.82k stars 303 forks source link

Switch to using suites concept in e2e tests #3010

Closed odockal closed 1 month ago

odockal commented 1 year ago

Is your enhancement related to a problem? Please describe

For now we have e2e:smoke npm task that runs only single e2e test we have now. We want to distinguish between smoke and full suite once there are more spec file.

Describe the solution you'd like

To have a modularized way to add new tests/files and have a way to share similar environment setup - starting the electron application.

// e2e-smoke.spec.ts is being called in npm task: e2e:smoke
import { afterAll, beforeAll, describe } from 'vitest';
import { testFeatureA } from './testFeatureA';
import { testFeatureB } from './testFeatureB';

describe('Smoke test suite', async () => {
    beforeAll(async () => { ... });
    afterAll(async () => { ... });
    await testFeatureA(...);
    await testFeatureB(...);
})

Describe alternatives you've considered

There are multiple options, we need to use the one working -> either, setup files or global setup, or using something called fixtures or text context (https://vitest.dev/guide/test-context.html#test-context) depending on if we talk about vitest or playwright.

Additional context

Using a vitest: There could be a problem with tests hooks hierarchy (https://github.com/vitest-dev/vitest/issues/3652) I have it found not really working as I was used to when using Mocha.

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

odockal commented 1 month ago

We have switched to different test runner.