containers / podman-desktop

Podman Desktop - A graphical tool for developing on containers and Kubernetes
https://podman-desktop.io
Apache License 2.0
4.46k stars 283 forks source link

Light icon/logo support #5116

Closed deboer-tim closed 1 week ago

deboer-tim commented 8 months ago

Is your enhancement related to a problem? Please describe

We have support for extensions to provide simple icons, or different ones for light vs dark mode. However, since we only have dark mode we have hardcoded many of these to only use light mode: ProviderLogo, PreferencesAuthentication, possibly ExtensionIcon (#5100).

Describe the solution you'd like

Simple component for displaying icons in either mode, which picks up the correct theme, and is reused in these places.

Describe alternatives you've considered

No response

Additional context

No response

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

cdrage commented 2 months ago

Screenshot 2024-06-11 at 8 18 39 AM

Kubernetes icon is still white / no dark mode for it.

deboer-tim commented 2 months ago

Kubernetes icon is still white / no dark mode for it.

This issue was created for extension icons/pngs in the files listed at the top. Light mode has been applied to the svgs in the main nav but my guess is a poor choice of color or wrong ref to color palette. But either way, can you open a separate issue to track?