Compose doesn't show proper components on GitHub Actions

containers / podman-desktop

Podman Desktop is the best free and open source tool to work with Containers and Kubernetes for developers. Get an intuitive and user-friendly interface to effortlessly build, manage, and deploy containers and Kubernetes — all from your desktop.

https://podman-desktop.io

Apache License 2.0

4.78k stars 300 forks source link

Compose doesn't show proper components on GitHub Actions #6175

Open xbabalov opened 7 months ago

xbabalov commented 7 months ago

Bug description

When running tests on GitHub Actions, the compose components that should've been there don't show. The label with instaled version in CLI Tools if it's already installed (or respectively the setup button for onboarding in Resources, if it's not installed already).

Operating system

Linux

Installation Method

None

Version

next (development version)

Steps to reproduce

No response

Relevant log output

No response

Additional context

Screenshots from a run of compose onboarding smoke tests on my fork in GitHub Actions:

Can_enter_Compose_onboarding_failure Verify_Compose_was_installed_failure

odockal commented 7 months ago

So simply, There is missing Setup button for compose, which could imply that it is installed already, but in the CLI tools there is no version and it looks like there is compose not available on the PATH. GHA runner description says that docker-compose is available on the machine (https://github.com/actions/runner-images/blob/main/images/ubuntu/toolsets/toolset-2204.json#L252), so we might be having a problem how are we testing docker-compose binary presence on the system. It seems like a "docker plugin" which I am not sure what does it mean.

xbabalov commented 7 months ago

I tried running docker-compose version, whereis docker-compose, which docker-compose, echo $PATH in a workflow of e2e-main.yaml and the results were

docker-compose version 1.29.2, build 5becea4c docker-py version: 5.0.0 CPython version: 3.7.10 OpenSSL version: OpenSSL 1.1.0l 10 Sep 2019
docker-compose: /usr/local/bin/docker-compose
/usr/local/bin/docker-compose
/opt/hostedtoolcache/node/20.11.1/x64/bin:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin in that order. So the compose version should be available to see in Podman Desktop in the CLI Tools page and it's probably a bug @cdrage. Link to the workflow run: https://github.com/xbabalov/podman-desktop/actions/runs/8296410107/job/22705383434

odockal commented 4 months ago

The CLI Tools part of this issue that points out that docker-compose is installed and so we should see the version available in CLI Tools is a dupe of https://github.com/containers/podman-desktop/issues/5250. Now, docker-compose is present on GHA Ubuntu runners, and so that is why there is no Setup button.

We can, on GHA ubuntu runner exclusively, remove or rename docker-compose prior test beginning, so the part of e2e test can actually run. Or keep it as it is.