containers / podman-desktop

Podman Desktop is the best free and open source tool to work with Containers and Kubernetes for developers. Get an intuitive and user-friendly interface to effortlessly build, manage, and deploy containers and Kubernetes — all from your desktop.
https://podman-desktop.io
Apache License 2.0
4.84k stars 306 forks source link

Refactor the circular dependecies in E2E test base #6411

Open odockal opened 7 months ago

odockal commented 7 months ago

Is your enhancement related to a problem? Please describe

In order to make the independent modules in testing base, we need to make sure the design and the code can be extracted. To achieve this we need to make sure not to have circular depndencies, ie: model modules has a dependency on utility modules, and the utility modules has deps to a model. (containersPage imports utility/operations and the same file uses other model/pages.)

Describe the solution you'd like

Remove the circular dependencies in order to make the modules independent.

Describe alternatives you've considered

One option would be to refactor model so it contains only page definitions, ie. locators only. any functions would then end up in different files, ie. handler or controller that would combine model with its functionality.

Additional context

No response

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!