fix(LoadingIconButton): consider failed state

containers / podman-desktop

Podman Desktop - A graphical tool for developing on containers and Kubernetes

https://podman-desktop.io

Apache License 2.0

4.22k stars 264 forks source link

fix(LoadingIconButton): consider failed state #6997

Closed axel7083 closed 3 weeks ago

axel7083 commented 3 weeks ago

What does this PR do?

The LoadingIconButton component used for the extensions action ('start' | 'delete' | ..) was not handling the scenarios where the action was deleted and the status was failed.

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes https://github.com/containers/podman-desktop/issues/6990

How to test this PR?

[x] Tests are covering the bug fix or the new feature

axel7083 commented 3 weeks ago

from a review POV, it's hard to know what is a refactoring and what is different as everything is changed at once

@benoitf waiting for https://github.com/containers/podman-desktop/pull/7014 to rebased this PR

axel7083 commented 3 weeks ago

rebased ✨