containers / podman-desktop

Podman Desktop - A graphical tool for developing on containers and Kubernetes
https://podman-desktop.io
Apache License 2.0
4.22k stars 264 forks source link

Installation collection of extensions through the `Install Custom Extension` has inconsistent button #6999

Closed axel7083 closed 1 week ago

axel7083 commented 3 weeks ago

Bug description

When installating a collection of extensions we have some weird Done -> Install -> Done -> Install with the models action buttons.

https://github.com/containers/podman-desktop/assets/42176370/f7550f3e-bc93-469d-b9de-02a056bf5b0a

Operating system

Windows 11

Installation Method

Other

Version

next (development version)

Steps to reproduce

Install a collection of extension

Relevant log output

No response

Additional context

Downloading sha256:[...].tar - [0 -> 100%]% - ([min]/[max])
Filtering image content...
Analyzing image [other extension]...
Downloading and extract layers...
Downloading sha256:[...].tar - [0 -> 100%]% - ([min]/[max])

etc.

We have a repetition of downloading images, filtering content and downloading images

https://github.com/containers/podman-desktop/blob/b6ffdbfe0ab31924356e07bf9c67d40b5059bf68/packages/renderer/src/lib/extensions/InstallManuallyExtensionModal.svelte#L148

And we are basing the state of the button on this percentage, which is a problem, as we can have several time the 100% we should instead wait for the following line to be awaited

https://github.com/containers/podman-desktop/blob/b6ffdbfe0ab31924356e07bf9c67d40b5059bf68/packages/renderer/src/lib/extensions/InstallManuallyExtensionModal.svelte#L53