containers / podman-desktop

Podman Desktop - A graphical tool for developing on containers and Kubernetes
https://podman-desktop.io
Apache License 2.0
4.22k stars 264 forks source link

fix: the Image.Id should contain sha256: prefix when listing image Id #7009

Closed benoitf closed 3 weeks ago

benoitf commented 3 weeks ago

What does this PR do?

To be compliant with compat API, the image Id needs to be prefixed (with podman it's not prefixed)

Screenshot / video of UI

What issues does this PR fix or reference?

fixes https://github.com/containers/podman-desktop/issues/6974

How to test this PR?

cdrage commented 3 weeks ago

https://github.com/containers/podman-desktop/assets/6422176/003195ed-4495-4b20-b422-429765ed73bc

So I checked this pretty thoroughly against an extension that uses image inspect, etc and it worked completely fine.

Had no issues doing multi-arch builds (it showed up in podman image ls and I could also do podman manifest inspect).

Thanks for noticing we need sha256 here!

LGTM!