Issues with Experimental Light mode for 1.11.0

containers / podman-desktop

Podman Desktop - A graphical tool for developing on containers and Kubernetes

https://podman-desktop.io

Apache License 2.0

4.33k stars 274 forks source link

Issues with Experimental Light mode for 1.11.0 #7750

Open cbr7 opened 2 weeks ago

cbr7 commented 2 weeks ago

Bug description

It seems there are no light mode version for the pages access through buttons from the additional actions sections of the main pages (e.g Play Kubernets YAML button from Pods page), all these pages are displayed in dark mode in PD version 1.11

https://github.com/containers/podman-desktop/assets/106525396/e0674d40-ab5b-4c2a-a61d-839bc4c86ddc

Operating system

macOS

Installation Method

Installer from website/GitHub releases

Version

next (development version)

Steps to reproduce

Install PD 1.11
Turn on light mode.
Go to "Play Kubernets YAML" page (or any menu accessed from additional actions buttons)
Notice the pages will be in dark mode.

Relevant log output

No response

Additional context

No response

cbr7 commented 2 weeks ago

Additional note: I've also noticed that the notification on the dashboard that directs the user to create a podman machine is also shown in dark mode

Also of note that the podman machine creation workflow/menus are all in dark mode even if light mode is enabled

deboer-tim commented 2 weeks ago

The dashboard supercharge section/banner is tracked via #7608. Form pages are tracked via #7214. Onboarding (machine creation) are covered through #7547 and #7548. The only thing I see that isn't already tracked is the Notifications section, @cbr7 do you want to open up a separate issue so that it's not buried, or change the title to focus on that?

In general you can scan epic #4914 to see what's done for light mode and what is still being tracked.

odockal commented 2 weeks ago

@deboer-tim Idea is to track all what we find during testing here and then compare with what we already know about. Please wait a little :) We can then close in case nothing new appears - or open separated issues, wdyt?

odockal commented 1 week ago

My findings so far, what is missing:

Resources
- Create New Cluster (Connection - machine, kind, sandbox, etc)
- Connection -> Logs
- Onboarding (again, any, will affect global onboarding - podman, compose, kubectl)
General
- dropdowns
- top Input box (aka press kube-context switch in system tray)
- any xterm, terminal, yaml viewer, etc. is also missing
Dashboard
- Notifications
Forms
- Build Image
- Run Image
- Pull Image
- Play Kube
- Deploy to Kubernetes
- Create Volume
Parts of the pages
- Export Container - also, in containers details, it is missaligned on the page, it does not have its own page
- Import container
- Save Image
- Load image
System Bar
- Tasks
- Feedback
- Troubleshooting
- Help

odockal commented 1 week ago

@deboer-tim We have now hopefully complete list of issue related to light mode. We need to compare that with epic for light mode.

deboer-tim commented 1 week ago

Epic is #4914 for reference. I did a quick comparison and I think the only thing were weren't tracking is the quick pick/top input box. Luca has fixed/PRs up for most of the forms in the current sprint, and we have ~half of the remaining work targeted to the next sprint.

odockal commented 1 week ago

@deboer-tim thanks! I will keep this open to compare in a while what all we got fixed.

kpiwko commented 1 week ago

Extensions also have issues with light mode, e.g. bootc is still dark.

deboer-tim commented 1 week ago

Extensions also have issues with light mode, e.g. bootc is still dark.

The current bootc extension (v1.2.0) should have a light homepage and then a dark form (similar to most of Podman Desktop in 1.11), but extension issues are tracked in their own repos, e.g.: https://github.com/containers/podman-desktop-extension-bootc/issues/536 for bootc and https://github.com/containers/podman-desktop-extension-ai-lab/issues/1209 for AI Lab.