containers / podman-desktop

Podman Desktop is the best free and open source tool to work with Containers and Kubernetes for developers. Get an intuitive and user-friendly interface to effortlessly build, manage, and deploy containers and Kubernetes — all from your desktop.
https://podman-desktop.io
Apache License 2.0
4.58k stars 292 forks source link

Native or styled menus? Ok to mix? #8336

Open deboer-tim opened 1 month ago

deboer-tim commented 1 month ago

Is your enhancement related to a problem? Please describe

Our action buttons (e.g. Container actions) use a styled drop down menu. If you select something that's a link inside Podman Desktop there's a native 'Copy Link' menu, and if you select text there's a native 'Copy' or 'Cut / Copy / Paste' menu depending on the context. The Accounts nav item has a native menu, but we're changing it to use our styling. The new Show/Hide nav uses a native menu.

Describe the solution you'd like

Is it ok to use both styles of menu or should they all be styled?

If they should all be styled we'll need to follow up with issues to convert or remove the existing native ones. If ok to mix, some of the native ones have menu items that don't make sense in our context (e.g. 'Copy Link') that should be removed.

Describe alternatives you've considered

No response

Additional context

No response

benoitf commented 1 month ago

I think it's ok as we should be/are using native for right click.

Also we're using libraries to handle the context menu (like inspect or copy element), then it would mean to reimplement something