search

containers / podman-desktop

Podman Desktop is the best free and open source tool to work with Containers and Kubernetes for developers. Get an intuitive and user-friendly interface to effortlessly build, manage, and deploy containers and Kubernetes — all from your desktop.
https://podman-desktop.io
Apache License 2.0
4.53k stars 290 forks source link

Add confirmation dialog to (Containers...) Delete selected items Button #8419

Open scscgit opened 1 month ago

scscgit commented 1 month ago

Is your enhancement related to a problem? Please describe

When selecting for example Containers or Volumes, there is a button to Delete N selected items. It instantly deletes the container/resource without any confirmation dialog, which is just terrible. Does anyone really prefer this behavior? Do you all only ever run temp containers and throwaway projects on your machines?

image

The delete button on the individual container's row correctly asks for confirmation, so you can reuse that.

image

Additionally, I'd like to ask if it would be reasonable to add more details on the Prune button's dialog, as it's currently empty and it's not easy to figure out what exactly will be removed. I found a related issue asking for a dry run option in the CLI command, which is what this popup could display: https://github.com/containers/podman/issues/19996

image

In general, it wouldn't hurt if Podman also had an option to mark an important resource (e.g. sticky) to avoid accidentally removing it, either by direct or bulk (Prune) removal. Though it's also true that Docker doesn't even implement something as trivial as directories yet, so our important resources always get mixed up with everything created ad-hoc that we often clean up (including use-cases like keeping backups of several old versions, plus it's difficult to group containers that we usually keep running to make it easy to return everything to default state if they get stopped, or to separate custom images from pulled ones). I wonder if it's intentional, or we're just so early that nobody seriously uses more than just a couple containers (without automation)...

Describe the solution you'd like

Delete confirmation dialog, or ways to also mark resources as important

Describe alternatives you've considered

Using Docker Desktop, where this works intuitively.

image

Additional context

Docker Desktop also says Any anonymous volumes associated with these containers are also deleted. when deleting Containers. Maybe this should be added to the Podman Desktop's popups too?

deboer-tim commented 1 month ago

The core request here (delete confirmation dialog) was just delivered in the 1.12 release via #7591. Could you take a look and either cancel this or update the description to be clear on what else you would like to see?