rename `working_dir` to `workdir` for consistency

containers / podman-py

Python bindings for Podman's RESTful API

Apache License 2.0

247 stars 90 forks source link

rename `working_dir` to `workdir` for consistency #332

Closed aparcar closed 8 months ago

aparcar commented 11 months ago

Currently podman-py uses all three versions of work_dir, working_dir and workdir (not to mention WorkingDir).

This commit tries to unify the parameter usage by allowing workdir for container create or run. For backwards compatibility working_dir still works but a deprecation warning is added.

Since upstream Podman uses a variety of workdir versions the podman-py codebase can't be simplified further.

Fix: #330

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aparcar Once this PR has been reviewed and has the lgtm label, please assign jwhonce for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/containers/podman-py/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

rhatdan commented 11 months ago

LGTM @umohnani8 @jwhonce @mwhahaha PTAL

umohnani8 commented 11 months ago

Changes LGTM gating is unhappy due to a format issue https://github.com/containers/podman-py/pull/332/checks?check_run_id=17258548350

rhatdan commented 10 months ago

@aparcar still working on this?

rhatdan commented 8 months ago

@umohnani8 Could you take this over and get it merged?