Closed renovate[bot] closed 12 months ago
cevich
commented
1 year ago @umohnani8 PTAL, there's likely going to be a gating-test failure about a circular-dependency. I don't know this code, but my past python experience tells me these can be very tricky to fix w/o code-base knowledge. Can you help or help track down someone who can fix this?
jwhonce
commented
1 year ago @cevich @umohnani8 This is going to take a deep drive into why pylint is throwing an error on podman/errors/exceptions.py:1:0: R0401: Cyclic import (podman.api -> podman.api.client) (cyclic-import) when that code was not changed.
cevich
commented
1 year ago when that code was not changed.
I don't think I have any idea how to do that, but I agree it's strange. Could it be caused by changed package/module names in an updated (third-party) dependency maybe?
cevich
commented
1 year ago ************* Module podman.errors.exceptions
podman/errors/exceptions.py:1:0: R0401: Cyclic import (podman.api -> podman.api.client) (cyclic-import)@jwhonce is there a way to make the output more verbose, to provide more clues?
umohnani8
commented
1 year ago So the cyclic import issue seems to be a bug with pylint based on https://github.com/pylint-dev/pylint/issues/3285 and https://github.com/pylint-dev/pylint/issues/3525. The issues say it has been fixed but our CI is still running into it even though I am not able to reproduce it locally with pylint podman.
I checked the pylint versions and locally I am on 2.14.2 while I believe the CI is on 3.0.2 - so not sure why it is running into that issue.
In https://github.com/containers/podman-py/pull/338 I have added a disable to that block to see if that works but I am not sure if it is the best way to go. @jwhonce wdyt?
umohnani8
commented
1 year ago Nevermind, the disable doesn't help with the cyclic import issue :(
cevich
commented
1 year ago Thanks for looking into this @umohnani8. I think we just need new CI VM images then, and a bit of luck they contain the fixed version.
cevich
commented
1 year ago Let's try these images built yesterday by Ed (thanks!)...
cevich
commented
1 year ago ...Ugh, no updated package yet, still get same error:
podman/errors/exceptions.py:1:0: R0401: Cyclic import (podman.api -> podman.api.client) (cyclic-import)
But at least now we know what to do/look for. There's a podman issue (IIRC) needing new CI VM images, and these ones I just tried are also no good there. Point is, there should be new images flowing through in the near-term.
umohnani8
commented
1 year ago @cevich I fixed the issue in https://github.com/containers/podman-py/pull/338. Once that is in, we should be good to rebase on top of that to get the tests passing here :)
rhatdan
commented
12 months ago /approve /lgtm
openshift-ci[bot]
commented
12 months ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cevich, renovate[bot], rhatdan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This PR contains the following updates:
20230816t191118z-f38f37d13->20231004t194547z-f39f38d13Release Notes
containers/automation_images (containers/automation_images)
### [`v20231004t194547z-f39f38d13`](https://togithub.com/containers/automation_images/compare/20230816t191118z-f38f37d13...20231004t194547z-f39f38d13) [Compare Source](https://togithub.com/containers/automation_images/compare/20230816t191118z-f38f37d13...20231004t194547z-f39f38d13)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.