search

containers / podman-py

Python bindings for Podman's RESTful API
Apache License 2.0
252 stars 94 forks source link

Update pull progress bar colour #341

Closed umohnani8 closed 11 months ago

umohnani8 commented 11 months ago

The Downloading bar is now in the default terminal text color and is bolded for better visibility. Bars will switch to green when completed.

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman-py/blob/main/OWNERS)~~ [umohnani8] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
umohnani8 commented 11 months ago

This is what the new output looks like image

@baude @jwhonce @TomSweeneyRedHat PTAL

baude commented 11 months ago

LGTM thanks for your work

edsantiago commented 11 months ago

Switching to bold is a good move: I tested with a colorblindness simulator, and it stands out under all models. It also looks much better to my eye. Plus, @baude's blessing carries a lot of weight. LGTM2.

baude commented 11 months ago

/lgtm

TomSweeneyRedHat commented 11 months ago

Late, but looks better to me than the red/green prior. Nice work @umohnani8