containers / podman-py

Python bindings for Podman's RESTful API
Apache License 2.0
252 stars 94 forks source link

Make progress_bar an extra feature #361

Closed yselkowitz closed 10 months ago

yselkowitz commented 10 months ago

This allows the 'rich' dependency, which has additional dependencies and is not available in RHEL, to be optional.

Fixes: #360

yselkowitz commented 10 months ago

/cc @umohnani8

lsm5 commented 10 months ago

LGTM.

@umohnani8 @TomSweeneyRedHat it's either this or we end up moving python-rich from EPEL to RHEL proper and also own it long term which could be lot more work for us.

cc @jnovy @jwhonce

rhatdan commented 10 months ago

/approve /lgtm

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman-py/blob/main/OWNERS)~~ [rhatdan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lsm5 commented 10 months ago

@umohnani8 I think we should get a new release out with this patch.

jnovy commented 10 months ago

Agree for the new release ASAP @lsm5

@yselkowitz this is brilliant, thank you!

umohnani8 commented 10 months ago

/cherry-pick release-4.8

openshift-cherrypick-robot commented 10 months ago

@umohnani8: new pull request created: #362

In response to [this](https://github.com/containers/podman-py/pull/361#issuecomment-1875223821): >/cherry-pick release-4.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
umohnani8 commented 10 months ago

Thanks for the fix @yselkowitz! LGTM

TomSweeneyRedHat commented 10 months ago

Neat change @yselkowitz ! Thanks for running this down and putting it together.