search

containers / podman-py

Python bindings for Podman's RESTful API
Apache License 2.0
252 stars 94 forks source link

Add `workdir` as alias for `working_dir` #368

Closed umohnani8 closed 9 months ago

umohnani8 commented 9 months ago

Currently podman-py uses all three versions of work_dir, working_dir and workdir (not to mention WorkingDir).

This commit tries to unify the parameter usage by allowing workdir for container create or run. For backwards compatibility working_dir still works.

Since upstream Podman uses a variety of workdir versions the podman-py codebase can't be simplified further.

Fix: #330

umohnani8 commented 9 months ago

Replacing https://github.com/containers/podman-py/pull/332

rhatdan commented 9 months ago

What about the tests?

umohnani8 commented 9 months ago

@rhatdan no tests are needed, we are just adding an alias

umohnani8 commented 9 months ago

@lsm5 @jwhonce @rhatdan PTAL

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman-py/blob/main/OWNERS)~~ [lsm5,umohnani8] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jwhonce commented 9 months ago

LGTM /hold cancel

umohnani8 commented 9 months ago

/hold cancel