containers / podman-py

Python bindings for Podman's RESTful API
Apache License 2.0
252 stars 94 forks source link

Remove deprecated max_pools_size arg #375

Closed umohnani8 closed 8 months ago

umohnani8 commented 8 months ago

Completely remove the depcrecated max_pools_size arg.

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman-py/blob/main/OWNERS)~~ [umohnani8] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
umohnani8 commented 8 months ago

@jwhonce @lsm5 @rhatdan PTAL

rhatdan commented 8 months ago

LGTM

umohnani8 commented 8 months ago

@jwhonce @rhatdan can I please get a lgtm to merge

rhatdan commented 8 months ago

/lgtm