Closed robbmanes closed 7 months ago
@jwhonce @umohnani8 PTAL
LGTM
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: robbmanes, umohnani8
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The Podman API clarifies the field to give is
dns_option
, notdns_options
here, so we need to drop thes
to allowdns_opt
fields to properly populate.I thought about writing more unit tests for
containers_create.py
but there weren't existing tests for any of the options yet, so we'll have to add them for each API option I'd think.Test program:
Now properly works since we're passing in the right name:
Note that it looks like
tox
is failing for unrelated reasons; I'm hoping the CI will have different results and it's just a local problem.