search

containers / podman-py

Python bindings for Podman's RESTful API
Apache License 2.0
252 stars 94 forks source link

Fix podman search flake + update CI VM images #418

Closed cevich closed 2 months ago

cevich commented 2 months ago

Podman search is an infrequently used feature, that tends to flake a lot. Also stop linting twice, and update CI VM images.

Example failure log: https://cirrus-ci.com/task/4801063868432384

inknos commented 2 months ago

Ugh pylint complains... Should we actually add that step as a flake? It is kinda annoying and not friendly to test it before pushing, and this leads to many force pushes. We could remove the pylint step from the chain and add it as a precommit to simplify all the checks

inknos commented 2 months ago

Besides pylint, I favor this change.

jwhonce commented 2 months ago

LGTM

cevich commented 2 months ago

It looks like the Gating test task also runs pylint. So I think it can just be dropped. Regardless, something else is broken with podman-search...

cevich commented 2 months ago

This should be ready to go now (assuming the changes are acceptable).

rhatdan commented 2 months ago

/approve /lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman-py/blob/main/OWNERS)~~ [rhatdan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment