search

containers / podman.io_old

Repository for podman.io website using GitHub Pages.
https://podman.io
Other
258 stars 135 forks source link

Fix matrix room link text to match link #579

Closed bluikko closed 1 year ago

bluikko commented 1 year ago

498 updated only the link itself to #podman:fedoraproject.org and left the link text to use the old #podman:matrix.org

So update the link text to match the link.

This is a new version after #578 was missing sign-off that was checked in the pipeline and GitHub web interface doesn't support amending commits.

It should be noted somewhere that sign-off is a requirement, maybe in the README or somewhere. Also other projects that require a sign-off have some configuration in GitHub that makes it possible to enable sign-off by enabling a tickbox on the GitHub web interface when doing commits.
Maybe I should open an issue for this?

TomSweeneyRedHat commented 1 year ago

LGTM but I want a head nod/LGTM from @lsm5 before merging. Thanks @bluikko !

lsm5 commented 1 year ago

RE: sign-off via github interface , @TomSweeneyRedHat @rhatdan @cevich wdyt?

bluikko commented 1 year ago

RE: sign-off via github interface , @TomSweeneyRedHat @rhatdan @cevich wdyt?

I opened #581 for that.