containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
23.64k stars 2.41k forks source link

podman secret usability #18591

Open jsonn opened 1 year ago

jsonn commented 1 year ago

Secret management has a number of small but annoying misfeatures:

  1. podman secret rm lacks an option to ignore errors from unknown secrets (compare podman container rm)
  2. podman secret create should also have an option for just replacing a secret if it already exists (compare podman container create).
  3. The check that "-" is not used with a tty for podman secret create is IMO completely bogus and should just be removed. It's perfectly sensible to type a password in when I know that no one is watching over my shoulder and it doesn't apply consistently anyway, since e.g. ssh myhost podman secreat create mysecret - just works fine.
rhatdan commented 1 year ago

Please open these as three different issues. Interested in opening PRs to fix anyone of them?

jsonn commented 1 year ago

I don't mind looking at it, if there is agreement on the direction.

rhatdan commented 1 year ago

The first two are no brainers. The third one would probably be fine as well, but I would like to have input from @vrothberg and @ashley-cui

vrothberg commented 1 year ago

Thanks for reaching out, @jsonn.

  1. That sounds good to me. Adding an --ignore flag can come in handy.
  2. A create --replace flag sounds good to me as well and is consistent with other commands.
  3. Sounds good as well.
ashley-cui commented 1 year ago

All sound like good ideas to me! Feel free to open PR's on them :)

github-actions[bot] commented 1 year ago

A friendly reminder that this issue had no activity for 30 days.

danishprakash commented 1 year ago

I can take a look at these if there's no one working on it atm.

rhatdan commented 1 year ago

You got it.

vrothberg commented 1 year ago

Thanks, @danishprakash !

github-actions[bot] commented 1 year ago

A friendly reminder that this issue had no activity for 30 days.

rhatdan commented 1 year ago

podman secret create --replace Has already been done.