search

containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
22.38k stars 2.31k forks source link

runtime-spec conversion does not follow current OCI spec #19459

Open mtrmac opened 11 months ago

mtrmac commented 11 months ago

Feature request description

https://github.com/opencontainers/image-spec/blob/main/conversion.md is fairly prescriptive about various image-spec fields that should be propagated to runtime-spec data, many as annotations.

From a (fairly brief and very ignorant) search of the Podman codebase, it seem that this is not currently happening.

I have absolutely no idea whether this makes any difference in practice.

vrothberg commented 11 months ago

@jakecorrenti, is that something you are interested in looking into (assuming you have time)? I think that's a great opportunity to dive into the image spec and how Podman uses it to create container specs.

jakecorrenti commented 11 months ago

Sure, I'd love to take a look

jakecorrenti commented 11 months ago

/assign

giuseppe commented 11 months ago

we need to be careful with what annotations are propagated into the runtime spec though there is an open PR to clarify the risk: https://github.com/opencontainers/image-spec/pull/1061

github-actions[bot] commented 10 months ago

A friendly reminder that this issue had no activity for 30 days.