containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
22.62k stars 2.31k forks source link

Podman v5 Quadlet .pod support for "ShmSize=" parameter #22915

Open poVoq opened 1 month ago

poVoq commented 1 month ago

Feature request description

Quadlet .container files support the ShmSize= option, however when running a container in a Pod, the ShmSize needs to be set at the Pod level.

When manually creating a Pod via pod create -n example-pod -p 1234:1234 --shm-size=1g this works fine, however when creating a Quadlet .pod file, the ShmSize= option is not available.

As a work-around the PodmanArgs=--shm-size=1g option seems to be working though.

Suggest potential solution

Like on individual .container level, the ShmSize= option should also work in .pod files.

Have you considered any alternatives?

As a work-around the PodmanArgs=--shm-size=1g option seems to be working in a .pod file.

Additional context

It is a bit odd that --shm-size=1g needs to be set at the Pod level and doesn't work at the container level when running a container in a Pod, but unless this changed in Podman5 it still seems to be true.

ygalblum commented 1 month ago

Thanks for bringing this up. The PodmanArgs key was added for this exact reason - to workaround missing keys. Care to open a PR to add the support for .pod files?

github-actions[bot] commented 3 weeks ago

A friendly reminder that this issue had no activity for 30 days.

Odilhao commented 2 weeks ago

@ygalblum I can take a look and add this to .pod files, just stumbled on this while using .pod in my lab.

ygalblum commented 2 weeks ago

@Odilhao, thanks for offering. I've assigned the issue to you. LMK if you need any help and/or tag me when you have the PR ready