search

containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
23.35k stars 2.38k forks source link

--squash --layers=false should be allowed #22957

Closed rhatdan closed 3 months ago

rhatdan commented 3 months ago

This is the same as what --squash-all is doing, and we already support --squash with --layers=true since this is the default.

Does this PR introduce a user-facing change?

You can now use `podman build --squash --layers=false` at the same time.
rhatdan commented 3 months ago

@mheon @Luap99 @nalind @baude @giuseppe @lsm5 @ashley-cui PTAL

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [giuseppe,rhatdan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nalind commented 3 months ago

/lgtm

packit-as-a-service[bot] commented 3 months ago

Cockpit tests failed for commit ad8fc6a74b7b82751678d8fe90c4efc7501a58bf. @martinpitt, @jelly, @mvollmer please check.