search

containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
23.35k stars 2.38k forks source link

Remove references to --pull=true and --pull=false #22967

Closed rhatdan closed 3 months ago

rhatdan commented 3 months ago

Does this PR introduce a user-facing change?

Fix documentation on default --pull value for podman build.
edsantiago commented 3 months ago

This seems like a pretty significant breaking change.

rhatdan commented 3 months ago

Only think different from my understanding is that always will attempt to pull even if the image exists in local storage, which is very wrong. where as newer will pull only if the image in the registry is different then the local one.

Hard to see how this could break anyone. @nalind @mtrmac Does --pull always actually replace the content in containers storage with the same content again, or does it pull and then realize it already has the content and drop it.

rhatdan commented 3 months ago

Oops my mistake, went from pull=missing to pull=newer to match Docker defaults to missing, reverting that change

mtrmac commented 3 months ago

An image is considered to be newer when the digests are different.

Per that, the newer is a just a lie.

I don’t immediately know what the options do in detail… it’s up to the author of the PR to understand the situation and advocate for a specific change.

c/image would typically not re-pull layers already present locally. For the most part, “pulling exactly the image again” should be a cheap enough mostly-metadata operation, such that “optimizing that out” by making another check should, ideally, not make things faster. In practice, there are complications.

So, I think the difference between newer and always is basically these complications.

rhatdan commented 3 months ago

@containers/podman-maintainers PTAL This is now pretty much just a documentation change. PTAL.
@giuseppe @nalind @mheon @mtrmac @flouthoc @baude @Luap99 PTAL

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [flouthoc,rhatdan,vrothberg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhatdan commented 3 months ago

Just for simplification of the code.