search

containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
23.33k stars 2.38k forks source link

ExitWithError, continued #22983

Closed edsantiago closed 3 months ago

edsantiago commented 3 months ago

Low-hanging fruit: Exit(X) with no error message is now ExitWithError(X, "")

Signed-off-by: Ed Santiago santiago@redhat.com

None
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [edsantiago] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
packit-as-a-service[bot] commented 3 months ago

Cockpit tests failed for commit 267d838e38b566b639624b4e702364a5a307ef50. @martinpitt, @jelly, @mvollmer please check.

rhatdan commented 3 months ago

LGTM

mheon commented 3 months ago

/lgtm