search

containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
23.33k stars 2.38k forks source link

ExitWithError() - more upgrades from Exit() #22987

Closed edsantiago closed 3 months ago

edsantiago commented 3 months ago

Add error-message checks to pod_xxxx_test.go

Signed-off-by: Ed Santiago santiago@redhat.com

None
edsantiago commented 3 months ago

Draft, because I don't think it'll pass CI (network error message diffs). Also, maybe #22986 will be fixed by the time I get back from PTO.

mheon commented 3 months ago

LGTM

edsantiago commented 3 months ago

This is ready. Rather than wait for #22986 and #22989, let's merge this now. Then whoever fixes those will have an almost-zero-effort test ready for them.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [Luap99,edsantiago] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment