containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
22.4k stars 2.31k forks source link

[skip-ci] Release workflow: Include candidate descriptor #22999

Closed cevich closed 2 weeks ago

cevich commented 3 weeks ago

Assist humans by indicating clearly whe a release announcement is pertaining to a candidate. Otherwise, it's possible someone may overlook the -rcX version suffix.

Does this PR introduce a user-facing change?

None
ashley-cui commented 3 weeks ago

LGTM

cevich commented 3 weeks ago

Heh, thanks Ashley, not quite ready yet. Running a test build, already found one lingering bug that needs fixing.

cevich commented 3 weeks ago

Manual test on a dummy v9.8.7-rc42 release:

cevich commented 3 weeks ago

Okay now this is ready :wink:

@mheon PLMK if the wording looks okay.

mheon commented 3 weeks ago

Sure, this LGTM

On Thu, Jun 13, 2024 at 5:24 PM Chris Evich @.***> wrote:

Okay now this is ready 😉

@mheon https://github.com/mheon PLMK if the wording looks okay.

— Reply to this email directly, view it on GitHub https://github.com/containers/podman/pull/22999#issuecomment-2166819419, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3AOCC6GVIBPR4VYAZOIQDZHIEX3AVCNFSM6AAAAABJJEY3DGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWHAYTSNBRHE . You are receiving this because you were mentioned.Message ID: @.***>

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, cevich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [ashley-cui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment