search

containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
23.31k stars 2.38k forks source link

fix(diff): do not suggest `--latest` when runs on remote with no args #23043

Closed miyamo2 closed 3 months ago

miyamo2 commented 3 months ago

When running diff with no args in podman-remote, the error message suggested the --latest flag. However, this flag does not exist in podman-remote, so the error message was modified to improve usability.

Closes: https://github.com/containers/podman/issues/23038

Does this PR introduce a user-facing change?

Improve error message in `podman-remote diff`. No longer suggesting flags that are not provided.
miyamo2 commented 3 months ago

@Luap99 My apologized. I guess I didn't make sense the issue until you pointed it out to me. I fixed them, and I'll add the test as well, so please wait for it.

baude commented 3 months ago

couple of things:

  1. should a test be added to prevent a regression on this?
  2. could you please provide at least something for the commit message?
  3. add a release note
miyamo2 commented 3 months ago

@baude Commit message and release notes have been added. Please check them. Thank you.

miyamo2 commented 3 months ago

@edsantiago Thank you, sir. I've applied your suggestion. Please check them.

rhatdan commented 3 months ago

Please squash your commits. git rebase -i origin git push --force

rhatdan commented 3 months ago

Code LGTM

miyamo2 commented 3 months ago

@rhatdan Thank you, sir. I squashed these commits. Regards.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miyamo2, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [vrothberg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment