search

containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
23.3k stars 2.37k forks source link

sqlite_state: Fix RewriteVolumeConfig #23053

Closed mariushoch closed 3 months ago

mariushoch commented 3 months ago

The VolumeConfig table does not have an ID column, thus use the Name column to update it. This will fix #23052.

Does this PR introduce a user-facing change?

Fixed podman system renumber if a volume exists.
Luap99 commented 3 months ago

Also please make sure to add Fixes #23052 to your commit message please

This should also probably be slated for a backport to 4.9.

4.9 is not supported anymore besides security updates.

mariushoch commented 3 months ago

Also please make sure to add Fixes #23052 to your commit message please

Done! Thanks for the swift feedback :)

This should also probably be slated for a backport to 4.9.

4.9 is not supported anymore besides security updates.

That's unfortunate, but understandable.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, mariushoch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
baude commented 3 months ago

code lgtm

mheon commented 3 months ago

/lgtm Evidence that we need to improve testing around this area, I think.