containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
22.37k stars 2.31k forks source link

container: pass StopTimeout to the systemd slice #23064

Closed giuseppe closed 1 week ago

giuseppe commented 1 week ago

Does this PR introduce a user-facing change?

Now Podman specifies the StopTimeout to systemd, so that it is honored when systemd stops the scope
rhatdan commented 1 week ago

LGTM @containers/podman-maintainers PTAL

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [Luap99,giuseppe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mheon commented 1 week ago

LGTM

On Fri, Jun 21, 2024 at 07:53 openshift-ci[bot] @.***> wrote:

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe https://github.com/containers/podman/pull/23064#, Luap99 https://github.com/containers/podman/pull/23064#pullrequestreview-2132488438

The full list of commands accepted by this bot can be found here https://go.k8s.io/bot-commands?repo=containers%2Fpodman.

The pull request process is described here https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

— Reply to this email directly, view it on GitHub https://github.com/containers/podman/pull/23064#issuecomment-2182606406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3AOCC6NZFJYWMSX6IEJLTZIQH3RAVCNFSM6AAAAABJVOSRTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSGYYDMNBQGY . You are receiving this because you are on a team that was mentioned.Message ID: @.***>

giuseppe commented 1 week ago

good to merge?

rhatdan commented 1 week ago

/lgtm