search

containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
22.36k stars 2.31k forks source link

macos-installer: bundle krunkit #23079

Closed slp closed 6 days ago

slp commented 6 days ago

Extend Makefile and package.sh to download, sign and bundle krunkit and its dependencies into the package.

Does this PR introduce a user-facing change?

None
rhatdan commented 6 days ago

LGTM @ashley-cui @lsm5 @baude @mheon PTAL

lsm5 commented 6 days ago

CI is happy, and changes look fine so LGTM from me FWIW. But, I'll defer to @ashley-cui as I have no idea about macos installer.

ashley-cui commented 6 days ago

/approve

openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, slp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [ashley-cui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment