Closed Luap99 closed 6 days ago
Ephemeral COPR build failed. @containers/packit-build please check.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: giuseppe, Luap99
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
libpod API: return proper error status code for pod start
When we failed to do anything we should return 500, the 409 code has a special meaing to the client as it uses a different error format. As such the remote client was not able to unmarshal the error correctly and just returned an empty string.
Fixes https://github.com/containers/podman/issues/22989
remote API: fix pod top error reporting
Do not return 200 status code before we know if there will be an error. Delay writing the status code until we send the first response. That way we can set an error code inside the loop when we get a error on the first try, i.e. because an invalid descriptor was used.
Fixes https://github.com/containers/podman/issues/22986
Does this PR introduce a user-facing change?