podman top: join the container userns

containers / podman

Podman: A tool for managing OCI containers and pods.

https://podman.io

Apache License 2.0

22.36k stars 2.31k forks source link

podman top: join the container userns #23096

Closed Luap99 closed 4 days ago

Luap99 commented 5 days ago

When we execute ps(1) in the container and the container uses a userns with a different id mapping the user id field will be wrong.

To fix this we must join the userns in such case.

Fixes #22293

Does this PR introduce a user-facing change?

Fix cases where podman top would show the incorrect uid for the processes when the container is using a user namespace.

Luap99 commented 5 days ago

@giuseppe PTAL

packit-as-a-service[bot] commented 5 days ago

Ephemeral COPR build failed. @containers/packit-build please check.

rhatdan commented 4 days ago

LGTM @giuseppe @vrothberg PTAL

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [Luap99,giuseppe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment