containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
22.36k stars 2.31k forks source link

cirrus: remove redundant skip logic and lower int timeout #23098

Closed Luap99 closed 4 days ago

Luap99 commented 5 days ago

cirrus: remove redundant skip logic

As of commit https://github.com/containers/podman/commit/d9183f0587950b8bdaebbc1ffe321965cb026397 we use the cirrus.yml skip logic to skip based on source changes. As such the add hoc logic inside our test setup can be removed. However as I did not yet implement the skip logic for all tests task in cirrus.yml it must remain for the other tasks for now. I plan to migrate the other in a week or two once we are confident that the cirrus.yml logic works well for us.


cirrus: reduce int tests timeout

Integration tests run around 15-20 mins now. Lower the timeout to 30m, if we hit this something is very wrong and needs to be looked at and there is no point in waiting much longer in case of a hang.

Does this PR introduce a user-facing change?

None
openshift-ci[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ashley-cui commented 5 days ago

LGTM

rhatdan commented 4 days ago

/lgtm