Closed Luap99 closed 5 days ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Luap99
The full list of commands accepted by this bot can be found here.
The pull request process is described here
And here I thought I could trick the needs tests check into thinking I added a test by removing a test file. Looks like I have to set the label then.
LGTM
/lgtm
Two tests are skipped for a long time because they flaked to much, nobody cares about them and there are only debugging endpoints mostly so it is not critical either.
The "of 2 seconds" tests isn't useful either. It waits up to 30s for the exit so it doesn't actually verify a proper timeout. Additionally we have similar checks in the system tests "podman system service - CORS enabled in logs" so I consider this safe to remove.
Fixes #12624
Does this PR introduce a user-facing change?