search

containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
22.36k stars 2.31k forks source link

[CI:BUILD] Minor: Rename the OSX Cross task #23105

Closed cevich closed 4 days ago

cevich commented 5 days ago

For many months this task has not been cross-compiling, it's building natively on a Mac. Avoid any possible confusion by renaming the task.

Does this PR introduce a user-facing change?

None
rhatdan commented 5 days ago

LGTM

cevich commented 5 days ago

Re-drafting: There's a bug in the artifacts task.

cevich commented 5 days ago

Fixed, now the artifacts task is working with the updated OSX task name.

cevich commented 4 days ago

Force-push: Renamed to "Build for MacOS amd64+arm64"

packit-as-a-service[bot] commented 4 days ago

Ephemeral COPR build failed. @containers/packit-build please check.

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Luap99 commented 3 days ago

I was about to comment yesterday that the implicit name -> URL dependency sucks as this is totally non obvious but didn't spend time actually checking for other places. Turns out it is used in more than one place... https://cirrus-ci.com/task/6562960993157120. This PR really should have not used CI:BUILD.

I already pushed a commit to fix it in my machine PR: https://github.com/containers/podman/pull/23118/commits/da2cbb0fe365a32a88431e3148fdf2e8cab793ad

cevich commented 3 days ago

implicit name -> URL dependency

Oof, yeah, this is really horrible. Sorry for assuming that the "artifacts" task was the only place :disappointed:

The only way I can think to "fix" this, is to add a comment on every relevant name: line warning humans to go searching for the URL-encoded lines. I'm not very happy about needing to do that though, so if you can think of a better solution (starlark?), PLMK.