containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
22.36k stars 2.31k forks source link

Do not use exit-dir, get exit status from perist_dir/ctr-id/exit #23108

Open dmitry-a-l opened 4 days ago

dmitry-a-l commented 4 days ago

Does this PR introduce a user-facing change?

None

Currently podman calls conmon with --exit-dir & --persist-dir flags, so conmon creates two exit files - one in the exit-dir and another one in the persist-dir and removes only the first file. This MR changes this behaviour - podman will not use exit-dir at all and will remove whole persist-dir after calling conmon

Closes #23107

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmitry-a-l Once this PR has been reviewed and has the lgtm label, please assign n1hility for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
packit-as-a-service[bot] commented 4 days ago

Ephemeral COPR build failed. @containers/packit-build please check.

lsm5 commented 4 days ago

Thanks for the PR @dmitry-a-l . It currently fails to build. Could you look at the build issues please?

 github.com/containers/podman/v5/libpod
cgo-gcc-prolog: In function ‘_cgo_108dfff6e81f_Cfunc_fork_exec_ps’:
cgo-gcc-prolog:62:49: warning: unused variable ‘_cgo_a’ [-Wunused-variable]
# github.com/containers/podman/v5/libpod
libpod/oci_conmon_common.go:933:23: multiple-value r.PersistDir(ctr) (value of type (string, error)) in single-value context
libpod/oci_conmon_common.go:939:23: multiple-value r.PersistDir(ctr) (value of type (string, error)) in single-value context
libpod/oci_missing.go:232:23: invalid operation: cannot call non-function persistDir (variable of type string)
libpod/oci_missing.go:243:23: invalid operation: cannot call non-function persistDir (variable of type string)
libpod/container_internal.go:11:2: "io/fs" imported and not used
error: Bad exit status from /var/tmp/rpm-tmp.xABZCz (%build)
dmitry-a-l commented 4 days ago

yeah, sure

will fix tomorrow

packit-as-a-service[bot] commented 4 days ago

Cockpit tests failed for commit aa5dba1ac3a1721ac3ab2135a437ebe40fda83de. @martinpitt, @jelly, @mvollmer please check.

packit-as-a-service[bot] commented 4 days ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 4 days ago

Cockpit tests failed for commit 150cca2477bb4fcb154b1c8c3947ea02d5792605. @martinpitt, @jelly, @mvollmer please check.

martinpitt commented 4 days ago

Cockpit tests timed out on podman pod stop -t0 pod-1, that's obviously related?