containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
22.36k stars 2.31k forks source link

Clearly indicate names w/ URLencoded duplicates #23125

Closed cevich closed 3 days ago

cevich commented 3 days ago

Previously it was easy for a maintainer to change a Cirrus-CI task name w/o realizing it would (later) cause a downstream task or the artifacts task to fail. This is due to duplication of task names in URLencoded format. Worse, artifacts task failures are inconsequential in PRs, and not all tasks are executed for every PR context (i.e. due to skip or only_if exclusions). So induced name change failures may not be noticed until after a PR merges.

Improve the visibility of the situation by adding comments to all consequential names. That is, task names where there is a URLencoded duplicate reference elsewhere.

Ref: https://github.com/containers/podman/pull/23105#issuecomment-2194270973

Does this PR introduce a user-facing change?

None
cevich commented 3 days ago

@Luap99 @edsantiago PTAL. TBH I'm not too happy with this workaround. I searched for a bit, but could not find any ready-made starlark modules with a urlencode() that would make this really easy to fix. The only other thing I could think of was to define a bunch of global envars for these task names, one normal and another (manually) urlencoded :disappointed: Happy to hear any suggestions you may have.

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [edsantiago] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cevich commented 3 days ago

Thanks guys. I wish there was a more elegant solution :disappointed: